misc: move predictive-perf off renderer i18n #12482
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the kind of weird legacy of the renderer's
i18n.js
(coming from autil
shared between the report and core),predictive-perf
ended up using the rendereri18n
class to do a simple milliseconds format rather than using the i18n pipeline (albeit for a string that no human will see or probably ever needs).Now, whether or not
predictive-perf
needs a properly localized and formatted milliseconds (instead of just doing rounding and addingms
itself locally) is another question, but this is basically free, so I don't think it matters. Either way it allows the rendereri18n
to not have optionalstrings
, which was my original goal with the change, so happy to change if someone feels strongly :)