Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: move predictive-perf off renderer i18n #12482

Merged
merged 1 commit into from
May 14, 2021
Merged

Conversation

brendankenny
Copy link
Member

Due to the kind of weird legacy of the renderer's i18n.js (coming from a util shared between the report and core), predictive-perf ended up using the renderer i18n class to do a simple milliseconds format rather than using the i18n pipeline (albeit for a string that no human will see or probably ever needs).

Now, whether or not predictive-perf needs a properly localized and formatted milliseconds (instead of just doing rounding and adding ms itself locally) is another question, but this is basically free, so I don't think it matters. Either way it allows the renderer i18n to not have optional strings, which was my original goal with the change, so happy to change if someone feels strongly :)

@brendankenny brendankenny requested a review from a team as a code owner May 14, 2021 22:05
@brendankenny brendankenny requested review from connorjclark and removed request for a team May 14, 2021 22:05
@google-cla google-cla bot added the cla: yes label May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants