core: rename uses-webp-images to modern-image-formats #12535
Conversation
|
would prefer "(uses-)?modern-image-formats" |
brendankenny
force-pushed
the
nextgenimages
branch
from
39bfa56
to
b680db9
Compare
"uses" is a no-go based on "Naming: Audit ID". To me "modern" sounds a little more mainstream. Like I expect something that's part of the "modern web" to work on the majority of evergreen browsers. I don't feel strongly about modern vs next-gen, though. |
There was a problem hiding this comment.
+1 to modern-image-formats
https://www.thesaurus.com/browse/modern: with-it-image-formats 👀?
| /** | ||
| * @return {LH.Audit.Meta} | ||
| */ | ||
| static get meta() { | ||
| return { | ||
| id: 'uses-webp-images', | ||
| id: 'next-gen-image-formats', | ||
| title: str_(UIStrings.title), | ||
| description: str_(UIStrings.description), |
There was a problem hiding this comment.
We should probably update the docs to mention AVIF at some point. Maybe deprecate the WebP article and write a new one?
There was a problem hiding this comment.
We should probably update the docs to mention AVIF at some point. Maybe deprecate the WebP article and write a new one?
👍 thats #12295
|
Note that the audit title has been "Serve images in next-gen formats" since Lighthouse 2.7.0, changed in #3985. This PR is only for the audit ID. Humorously from #3985 and #3557 it appears @patrickhulce has long been in favor of "next gen" but @paulirish was against it, though later decided he was fine with the name :) |
haha. In #3985 (comment) Paul suggested |
Haha, oooooh "superior" and "performant" -- hardworking, alphamale, jackhammer, merciless, insatiable image formats 😈 I prefer |
|
OK, unless he says otherwise, I'm going to assume @paulirish would also prefer
|
|
(all the stack-pack strings will get readded in the next dump->import cycle since only their name changed, not their content) |
brendankenny
changed the title
|
Fwiw, +1 on |
| @@ -25,13 +25,13 @@ const str_ = i18n.createMessageInstanceIdFn(__filename, UIStrings); | |||
|
|
|||
| const IGNORE_THRESHOLD_IN_BYTES = 8192; | |||
|
|
|||
| class UsesWebPImages extends ByteEfficiencyAudit { | |||
| class NextGenImageFormats extends ByteEfficiencyAudit { | |||
There was a problem hiding this comment.
| class NextGenImageFormats extends ByteEfficiencyAudit { | |
| class ModernImageFormats extends ByteEfficiencyAudit { |
and co
part of #11866
With webp now being mainstream and AVIF and jpeg XL on their way, we're renaming the
uses-webp-imagesaudit to better reflect its goal, which is to suggest usingnext-gen*ahem* "modern" image formats (via e.g.<picture>), even if they're not available everywhere yet. See #12295 for details.We didn't totally agree on this name yet, so we can decide here, which will be fun, and then I'll update GoogleChrome/lighthouse-stack-packs#63 to match.done