core: remove estimated-input-latency and first-cpu-idle #12553
Conversation
| 'first-cpu-idle': { | ||
| numericValue: '>2000', | ||
| }, | ||
| // TODO: ? |
There was a problem hiding this comment.
Should I replace these smoke expectations with something else?
There was a problem hiding this comment.
nah. FCI is basically TTI and TTI is already there.
|
what happened to |
|
I started just removing the EIL/FCI references then decided to just strip the entire thing but what is needed for treemap |
|
could you split that and we could just land that quickly independently of other changes? e.g. I updated individual lines in |
There was a problem hiding this comment.
a few more things you'll see if you search FCPUI.
- There's a few errors that appear to be safe to delete. (they were never in the proto
- And there's a block in
lantern-baseline-accuracy.jsonthat you'll need to delete.
(and the devtools tests need a rebaseline)
| 'first-cpu-idle': { | ||
| numericValue: '>2000', | ||
| }, | ||
| // TODO: ? |
There was a problem hiding this comment.
nah. FCI is basically TTI and TTI is already there.
| 'first-cpu-idle': { | ||
| score: '>=0.90', // primarily just making sure it didn't fail/go crazy, specific value isn't that important | ||
| }, | ||
| // TODO ? |
| @@ -17,10 +17,11 @@ module.exports = [ | |||
| requestedUrl: 'http://localhost:10200/tricky-tti.html', | |||
| finalUrl: 'http://localhost:10200/tricky-tti.html', | |||
| audits: { | |||
| 'first-cpu-idle': { | |||
There was a problem hiding this comment.
on these you could add assertions for TBT if you want, but i don't think that's necessary or a great test for that metric.
so i'm +1 on removing in this file too
|
@paulirish has got this one under control 👍 |
| 'first-cpu-idle': { | ||
| numericValue: '>2000', | ||
| }, | ||
| // TODO: ? |
| assert.equal(EstimatedInputLatency.calculateRollingWindowEIL(events), 4516); | ||
| }); | ||
|
|
||
| it('handles continuous tasks', async () => { |
There was a problem hiding this comment.
good stuff in here. Oh well :)
ref #11866