core(fr): fix usage of distributed conditional type #12565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickhulce
approved these changes
May 26, 2021
types/gatherer.d.ts
Outdated
| @@ -45,7 +45,7 @@ declare global { | |||
| /** The cached results of computed artifacts. */ | |||
| computedCache: Map<string, ArbitraryEqualityMap>; | |||
| /** The set of available dependencies requested by the current gatherer. */ | |||
| dependencies: TDependencies extends DefaultDependenciesKey ? | |||
| dependencies: [TDependencies] extends [DefaultDependenciesKey] ? | |||
There was a problem hiding this comment.
DefaultDependenciesKey isn't actually a union, just an alias, so I wouldn't expect to need brackets around that.
Suggested change
| dependencies: [TDependencies] extends [DefaultDependenciesKey] ? | |
| dependencies: [TDependencies] extends DefaultDependenciesKey ? |
|
btw I think this exposes a real type failure in the places where we assumed |
These were the issues that appeared when we removed the condition. I'm gonna try removing the condition to see if that works. |
connorjclark
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Incorrect behavior when defining multiple dependencies in
FRTransitionalContext. This was caused by distributed conditional types.