core(script-treemap-data): do not create nodes with blank names #12569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorjclark
commented
May 26, 2021
| @@ -273,7 +314,7 @@ describe('ScriptTreemapData audit', () => { | |||
| expect(node.name).toBe('some/prefix'); | |||
| expect(node.resourceBytes).toBe(201); | |||
| expect(node.unusedBytes).toBe(101); | |||
| expect(node.children && node.children[0].name).toBe('/main.js'); | |||
| expect(node.children && node.children[0].name).toBe('main.js'); | |||
There was a problem hiding this comment.
love this change
|
Before / After:
|
paulirish
approved these changes
May 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing the treemap button in PSI, I noticed errors b/c of how we drop empty string values in the LHR.
script-treemap-datawraps the nodes for a bundle in two layers: top is the script src node, second is the sourceRoot node. But sourceRoot can be an empty string/not there, so this resulted in nodes where name was''. There's an extra complication w/ thecollapsefunctionality, but it isn't relevant to the issue so I won't describe it in detail.root//b.jsexist and will make annoying extra layers of nodes named/or (b/c collapsing)/b.js. so I do an extra check in the.splitforEach to prevent that.makeCaptionfunction not totally kill everything when name is missing.