core(network-request): consider HSTS redirects secure #12681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (!destination) return false; | ||
|
|
||
| const reasonHeader = record.responseHeaders | ||
| .find(header => header.name === 'Non-Authoritative-Reason'); |
There was a problem hiding this comment.
ha, I wonder how this header ended up with this name
There was a problem hiding this comment.
https://www.w3.org/Protocols/rfc2616/rfc2616-sec10.html#sec10.2.4
non-authorative because the info (the redirect) comes from a third party (hsts list in the browser), not the intended origin
adamraine
approved these changes
Jun 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Often the HTTPS audit fails because the original URL audited was
http, so even if it redirects then you still have the original redirect request over HTTP. We can kinda explain why this is desirable (though I'm not really sold it's worth the annoyance), but it's definitely not the case in HSTS internal redirects that happen in the browser, which is the whole point of HSTS. This applies to entire TLDs in some cases (.app/.dev), so we should handle those cases appropriately.Related Issues/PRs
fixes #12674