core(fr): enable traces artifact in timespan mode #12695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickhulce
force-pushed
the
fr_traces_in_timespan
branch
from
413ea3e
to
fd45bca
Compare
connorjclark
approved these changes
Jun 24, 2021
| observedLargestContentfulPaint: processedNavigation && processedNavigation.timings.largestContentfulPaint, // eslint-disable-line max-len | ||
| observedLargestContentfulPaintTs: processedNavigation && processedNavigation.timestamps.largestContentfulPaint, // eslint-disable-line max-len | ||
| observedLargestContentfulPaintAllFrames: processedNavigation && processedNavigation.timings.largestContentfulPaintAllFrames, // eslint-disable-line max-len | ||
| observedLargestContentfulPaintAllFramesTs: processedNavigation && processedNavigation.timestamps.largestContentfulPaintAllFrames, // eslint-disable-line max-len |
There was a problem hiding this comment.
not soon enough! haha
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Enables the traces artifact in timespan mode! 🎉
supportedMode: ['navigation']if they don't immediately work in timespan mode (@adamraine to do a deeper pass on these for a breakup plan).wastedMscomputation method for opportunities to use until the rework.findMainDocumentwith a newfindOptionalMainDocumentversion that returnsundefinedinstead of throwing.See https://melodic-class.glitch.me/cerealshack-timespan.html for what a timespan report looks like after this.
Related Issues/PRs
ref #11313
ref #12595