misc(build): add build step for report #12707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorjclark
commented
Jun 25, 2021
| @@ -39,6 +39,9 @@ mkdir -p "$fe_lh_dir" | |||
|
|
|||
| lh_bg_js="dist/lighthouse-dt-bundle.js" | |||
|
|
|||
| yarn build-report | |||
| yarn build-devtools | |||
There was a problem hiding this comment.
drive by change to also build devtools when rolling
patrickhulce
approved these changes
Jun 25, 2021
| @@ -31,7 +32,7 @@ | |||
| "lint": "[ \"$CI\" = true ] && eslint --quiet -f codeframe . || eslint .", | |||
| "smoke": "node lighthouse-cli/test/smokehouse/frontends/smokehouse-bin.js", | |||
| "debug": "node --inspect-brk ./lighthouse-cli/index.js", | |||
| "start": "node ./lighthouse-cli/index.js", | |||
| "start": "yarn build-report && node ./lighthouse-cli/index.js", | |||
connorjclark
changed the title
|
I'll defer to @brendankenny on the last remaining point. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
breaking off some work from #12702
not using rollup here. I tried, but it was more effort than desired to get our weird exports working via commonjs+rollup, and this is just a transient change, so nbd.