misc(scripts): check for UIStrings text before using require #12722
Conversation
| // No UIStrings found in the file text or exports, so move to the next. | ||
| if (!exportedUIStrings) continue; | ||
|
|
||
| throw new Error('UIStrings exported but no definition found'); |
There was a problem hiding this comment.
I know I suggested this, so, my fault, but I think we don't want to get rid of this error because it catches non-standard UIStrings declarations that won't parse with tsc, and without it I believe you won't have any warning about your mistake (except if you notice that en-US.json wasn't updated in the commit diff).
Should we just add some form of standalone to the ignoredPathComponents?
There was a problem hiding this comment.
Should we just add some form of standalone to the ignoredPathComponents?
+1 if the goal here is to make this script work for standalone report only
I see a future in which we want to have this script work on files that work in the browser though in which case we need a longer term answer for both concerns.
Alternatives:
- we have two UIStrings regex, one that's simpler for any
UIStringsuse, and then our current definition one. We only skip import if there's no mention ofUIStrings, period. - we shim browser dependencies necessary to be able to import the keys at least
minor change, needed to play nice with
standalone.jsin #12702 (requiring causes script to error b/cdocument, etc. does not exist)