report(psi): update styles for tighter fit in narrow viewports #13355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If this isn't expecting any more changes, can you add some before/after pics? |
nothing in the non-psi except avoiding an extra 1px border in single-category:
and i've added screenshots about the psi stuff to the PR description. |
|
@connorjclark no rush but can you take a look |
connorjclark
approved these changes
Dec 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see https://lighthouse-git-psitweakz-googlechrome.vercel.app/sample-reports/%E2%8C%A3.psi.english
in faux PSI things look a lot different in general... goal being that faux-psi is a more representative testing ground:
and here's the change in narrow viewports
this is fine to be post v9. i'm gonna be rolling some cherrypicks for a bit