report: remove pausing fireworks on click #13650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorjclark
changed the title
adamraine
approved these changes
Feb 9, 2022
paulirish
approved these changes
Feb 10, 2022
There was a problem hiding this comment.
this sg
the original motivation for click to pause was basically a manual indication of 'i want less motion'
so i was about to suggest we we also add in a https://developer.mozilla.org/en-US/docs/Web/CSS/@media/prefers-reduced-motion rule to set the play-state to paused?
but i tried it and even after futzing it a bit, this is the ~best it'd get... just totally frozen like this:
which isn't great.
so yeah i'm good with yr change :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the fireworks are paused it seems like something bugged out ... the only reason to allow pausing is to remove them as a distraction so you can read what they are above. but the only thing they are above are a bunch of 100s... as you scroll down the fireworks go away. So I don't think this is necessary.