report: render notApplicable metrics with double dash #13981
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #13916
@adamraine convinced me in that issue that we should just use
scoreDisplayMode
notApplicable
to allow metrics to declare themselves not-applicable, but (unlike all other audits) still be displayed in the report. This allows for "optional" metrics like responsiveness to correctly appear in timespan reports, even if there were no interactions in that timespan.I still think there's a chance we won't want to eliminate the only way audits can dynamically remove themselves from the report, but that chance seems very slim since we've never done this with a metric before in the four years since metric rendering was changed much, and I think we'll still be able to change our minds without really breaking backwards/forwards compatibility with report rendering.
All that said: how should this look? Almost everything was already working so this PR is just adding some placeholder text. It's pretty weak right now, open to ideas :)
notApplicable
audits can still have theirdisplayValue
set and could set their own string there. Would that be better? Would need to make sure the string (and translations) fit.