Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: update to typescript 5.0.4 #15023

Merged
merged 2 commits into from
Apr 28, 2023
Merged

deps: update to typescript 5.0.4 #15023

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0d95f72
deps: update to typescript 5.0.4
connorjclark Apr 27, 2023
2fc58b4
ts.factory.createNotEmittedStatement
connorjclark Apr 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build/build-cdt-lib.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,7 @@ function doModification(modification) {
}

if (removeNode) {
return ts.createNode(ts.SyntaxKind.Unknown);
return ts.factory.createNotEmittedStatement(node);
}

return node;
Expand Down
2 changes: 1 addition & 1 deletion core/legacy/gather/gather-runner.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -452,7 +452,7 @@ class GatherRunner {
// Add a `bidx=20` query param, eg: https://www.example.com/?bidx=50
const parsedUrl = UrlUtils.isValid(options.requestedUrl) && new URL(options.requestedUrl);
if (options.settings.channel === 'lr' && parsedUrl && parsedUrl.searchParams.has('bidx')) {
const bidxRunCount = parsedUrl.searchParams.get('bidx') || 0;
const bidxRunCount = Number(parsedUrl.searchParams.get('bidx')) || 0;
// Add the first bidx into the new set
const indexes = [baseArtifacts.BenchmarkIndex];
for (let i = 0; i < bidxRunCount; i++) {
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@
"terser": "^5.3.8",
"testdouble": "^3.16.8",
"typed-query-selector": "^2.6.1",
"typescript": "^4.9.4",
"typescript": "^5.0.4",
"wait-for-expect": "^3.0.2",
"webtreemap-cdt": "^3.2.1"
},
Expand Down
2 changes: 1 addition & 1 deletion types/internal/test.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

declare global {
var expect: import('expect').Expect;
type Mock<T, Y> = import('jest-mock').Mock<T, Y>;
type Mock<T, Y extends unknown[]> = import('jest-mock').Mock<T, Y>;
}

declare module 'expect' {
Expand Down
8 changes: 4 additions & 4 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7239,10 +7239,10 @@ typedarray-to-buffer@^3.1.5:
dependencies:
is-typedarray "^1.0.0"

typescript@^4.9.4:
version "4.9.4"
resolved "https://registry.yarnpkg.com/typescript/-/typescript-4.9.4.tgz#a2a3d2756c079abda241d75f149df9d561091e78"
integrity sha512-Uz+dTXYzxXXbsFpM86Wh3dKCxrQqUcVMxwU54orwlJjOpO3ao8L7j5lH+dWfTwgCwIuM9GQ2kvVotzYJMXTBZg==
typescript@^5.0.4:
version "5.0.4"
resolved "https://registry.yarnpkg.com/typescript/-/typescript-5.0.4.tgz#b217fd20119bd61a94d4011274e0ab369058da3b"
integrity sha512-cW9T5W9xY37cc+jfEnaUvX91foxtHkza3Nw3wkoF4sSlKn0MONdkdEndig/qPBWXNkmplh3NzayQzCiHM4/hqw==

uglify-js@^3.1.4:
version "3.14.4"
Expand Down