Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: rebaseline inspector issue detail types #15050

Merged
merged 3 commits into from
May 5, 2023
Merged

tests: rebaseline inspector issue detail types #15050

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
500a0b7
tests: rebaseline inspector issue detail types
connorjclark May 5, 2023
34f09c1
rm
connorjclark May 5, 2023
190aa36
lint
connorjclark May 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion core/gather/gatherers/inspector-issues.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,6 @@ class InspectorIssues extends FRGatherer {
quirksModeIssue: [],
cookieIssue: [],
sharedArrayBufferIssue: [],
twaQualityEnforcement: [],
};
const keys = /** @type {Array<keyof LH.Artifacts['InspectorIssues']>} */(Object.keys(artifact));
for (const key of keys) {
Expand Down
1 change: 0 additions & 1 deletion core/test/audits/dobetterweb/inspector-issues-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ describe('Has inspector issues audit', () => {
quirksModeIssue: [],
cookieIssue: [],
sharedArrayBufferIssue: [],
twaQualityEnforcement: [],
};
});

Expand Down
3 changes: 1 addition & 2 deletions core/test/fixtures/fraggle-rock/artifacts/step0/artifacts.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1966,8 +1966,7 @@
"navigatorUserAgentIssue": [],
"quirksModeIssue": [],
"cookieIssue": [],
"sharedArrayBufferIssue": [],
"twaQualityEnforcement": []
"sharedArrayBufferIssue": []
},
"JsUsage": {
"8": {
Expand Down
3 changes: 1 addition & 2 deletions core/test/fixtures/fraggle-rock/artifacts/step1/artifacts.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1557,8 +1557,7 @@
],
"quirksModeIssue": [],
"cookieIssue": [],
"sharedArrayBufferIssue": [],
"twaQualityEnforcement": []
"sharedArrayBufferIssue": []
},
"JsUsage": {
"16": {
Expand Down
3 changes: 1 addition & 2 deletions core/test/fixtures/fraggle-rock/artifacts/step3/artifacts.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2020,8 +2020,7 @@
],
"quirksModeIssue": [],
"cookieIssue": [],
"sharedArrayBufferIssue": [],
"twaQualityEnforcement": []
"sharedArrayBufferIssue": []
},
"JsUsage": {
"16": {
Expand Down
4 changes: 0 additions & 4 deletions core/test/gather/gatherers/inspector-issues-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,7 +245,6 @@ describe('_getArtifact', () => {
navigatorUserAgentIssue: [],
quirksModeIssue: [],
sharedArrayBufferIssue: [],
twaQualityEnforcement: [],
federatedAuthRequestIssue: [],
});
});
Expand Down Expand Up @@ -303,7 +302,6 @@ describe('_getArtifact', () => {
navigatorUserAgentIssue: [],
quirksModeIssue: [],
sharedArrayBufferIssue: [],
twaQualityEnforcement: [],
federatedAuthRequestIssue: [],
});
});
Expand Down Expand Up @@ -368,7 +366,6 @@ describe('FR compat (inspector-issues)', () => {
navigatorUserAgentIssue: [],
quirksModeIssue: [],
sharedArrayBufferIssue: [],
twaQualityEnforcement: [],
federatedAuthRequestIssue: [],
});
});
Expand Down Expand Up @@ -405,7 +402,6 @@ describe('FR compat (inspector-issues)', () => {
navigatorUserAgentIssue: [],
quirksModeIssue: [],
sharedArrayBufferIssue: [],
twaQualityEnforcement: [],
federatedAuthRequestIssue: [],
});
});
Expand Down
3 changes: 1 addition & 2 deletions core/test/results/artifacts/artifacts.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12045,8 +12045,7 @@
],
"quirksModeIssue": [],
"cookieIssue": [],
"sharedArrayBufferIssue": [],
"twaQualityEnforcement": []
"sharedArrayBufferIssue": []
},
"SourceMaps": [],
"FullPageScreenshot": {
Expand Down
1 change: 0 additions & 1 deletion third-party/chromium-synchronization/inspector-issueAdded-types-test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@ Array [
"navigatorUserAgentIssueDetails",
"quirksModeIssueDetails",
"sharedArrayBufferIssueDetails",
"twaQualityEnforcementDetails",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add a note to remove this everywhere once the change hits stable?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nah let's just kill it now

]
`);
});
Expand Down
1 change: 0 additions & 1 deletion types/artifacts.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -617,7 +617,6 @@ declare module Artifacts {
quirksModeIssue: Crdp.Audits.QuirksModeIssueDetails[];
cookieIssue: Crdp.Audits.CookieIssueDetails[];
sharedArrayBufferIssue: Crdp.Audits.SharedArrayBufferIssueDetails[];
twaQualityEnforcement: Crdp.Audits.TrustedWebActivityIssueDetails[];
}

// Computed artifact types below.
Expand Down