Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor critical-request-chains-test.js log code. #1509

Merged
merged 1 commit into from
Jan 23, 2017
Merged

Refactor critical-request-chains-test.js log code. #1509

merged 1 commit into from
Jan 23, 2017

Conversation

XhmikosR
Copy link
Contributor

@XhmikosR XhmikosR commented Jan 22, 2017 •
edited
Loading

Now tests should pass on all platforms.

Part of the ongoing work to have tests pass on Windows.

@XhmikosR
Refactor critical-request-chains-test.js log code.
2f10407 
Now tests should pass on all platforms.
paulirish
paulirish approved these changes Jan 23, 2017
View reviewed changes
Copy link
Member

@paulirish paulirish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mucho bueno

@paulirish paulirish merged commit a690335 into GoogleChrome:master Jan 23, 2017
@XhmikosR XhmikosR deleted the log-windows-fixes branch January 23, 2017 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulirish paulirish paulirish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@XhmikosR @paulirish