Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc: remove url hash to avoid gtm hang in treemap, viewer #15425

Merged
merged 2 commits into from
Aug 30, 2023

Conversation

connorjclark
Copy link
Collaborator

See b/298230436

@connorjclark connorjclark requested a review from a team as a code owner August 30, 2023 19:11
@connorjclark connorjclark requested review from adamraine and removed request for a team August 30, 2023 19:11
Copy link
Member

@adamraine adamraine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smoke failures would be fixed by #15422, I'm good to force merge over that.

There is a type error that we should fix though.

// b/298230436
window.__hash = window.location.hash;
window.location.hash = '';
</script>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be above bundled.js and the other scripts?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks at both, so either way 🤷

@connorjclark connorjclark merged commit eed3bb4 into main Aug 30, 2023
23 of 27 checks passed
@connorjclark connorjclark deleted the treemap-gtm-hang branch August 30, 2023 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants