Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor CSS consistency changes: #1627

Merged
merged 1 commit into from
Feb 3, 2017
Merged

Minor CSS consistency changes: #1627

merged 1 commit into from
Feb 3, 2017

Conversation

XhmikosR
Copy link
Contributor

@XhmikosR XhmikosR commented Feb 3, 2017

  • use lowercase hex colors
  • use numeric font-weight values
  • remove units from zero

@XhmikosR
Minor CSS consistency changes:
2287252 
* use lowercase hex colors
* use numeric font-weight values
* remove units from zero
@ebidel
Copy link
Contributor

ebidel commented Feb 3, 2017

Thanks for the change. IMO, it's generally hard to be consistent (and enforce) formatting without a proper CSS linter. But LGTM.

@ebidel ebidel merged commit 81b891d into GoogleChrome:master Feb 3, 2017
@XhmikosR XhmikosR deleted the css-consistency branch February 3, 2017 19:09
@XhmikosR
Copy link
Contributor Author

XhmikosR commented Feb 3, 2017

Agreed. Might be worth looking into stylelint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebidel ebidel ebidel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@XhmikosR @ebidel