Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More concise unit test running #1650

Merged
merged 4 commits into from
Feb 7, 2017
Merged

More concise unit test running #1650

merged 4 commits into from
Feb 7, 2017

Conversation

paulirish
Copy link
Member

@paulirish paulirish commented Feb 7, 2017

Update: only dot now.. no more landing strip :(

Using the landing strip reporter for us. It looks like this:
untitled

Pretty nice as it gives some idea of progress through the suite.

Travis logs every screen change, so I swapped it to the dot reporter, which looks like this:
image

Errors in the suite are still reported the exact same way. It's just you see the progress differently


a few other things:

  • in chrome-launcher-test I silenced all the logging output (all about "waiting for browser.."
    • This required changing how we tell debug() to shut up, but I like this way better
  • similarly, the pipe change in index-test was to avoid seeing "Please provide a url" logged to terminal
  • And I also nuked some unused CSS in a driveby

PTAL!

@ebidel
Copy link
Contributor

ebidel commented Feb 7, 2017

Nice. I've always been fond of the dot. It gives you progress and extra information. Should we just stick with one, or do you like the runway? I mean, ✈️ are pretty cool.

@patrickhulce
Copy link
Collaborator

Nice, landing is pretty dope. I do miss that we won't have visibility into which tests take forever (although we haven't around to using that information much yet I guess) but the output was insane before.

@brendankenny
Copy link
Member

Should we just stick with one, or do you like the runway? I mean, ✈️ are pretty cool.

ha, I probably would prefer dot locally as well. Something about the progress bar not actually being 1:1 with the tests feels unsatisfying to me

@brendankenny
Copy link
Member

why did you have to manually suppress the logging in chrome-launcher-test.js but not in e.g. gather-runner-test.js, which has gotten a bit annoying with it's logged errors but isn't logging here anymore?

@paulirish
Copy link
Member Author

why did you have to manually suppress the logging in chrome-launcher-test.js but not in e.g. gather-runner-test.js, which has gotten a bit annoying with it's logged errors but isn't logging here anymore?

I wasn't seeing it logging, but if it is, i'm happy to apply the suppression there too. :)

@paulirish
Copy link
Member Author

dot FTW. changed it to always be that.

Also check out the height of this travis log: https://travis-ci.org/GoogleChrome/lighthouse/jobs/199341666 oh yeah. :)

LGTMs?

@brendankenny
Copy link
Member

I wasn't seeing it logging, but if it is, i'm happy to apply the suppression there too. :)

ha, same, I was just wondering how that happened. Did a few lighthouse runs and diffed the logs and everything looks the same, though

Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

....L✈️TM........

@brendankenny brendankenny merged commit 5403bc3 into master Feb 7, 2017
@brendankenny brendankenny deleted the landingmocha branch February 7, 2017 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants