-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More concise unit test running #1650
Conversation
Nice. I've always been fond of the dot. It gives you progress and extra information. Should we just stick with one, or do you like the runway? I mean, |
Nice, landing is pretty dope. I do miss that we won't have visibility into which tests take forever (although we haven't around to using that information much yet I guess) but the output was insane before. |
ha, I probably would prefer dot locally as well. Something about the progress bar not actually being 1:1 with the tests feels unsatisfying to me |
why did you have to manually suppress the logging in |
I wasn't seeing it logging, but if it is, i'm happy to apply the suppression there too. :) |
Also check out the height of this travis log: https://travis-ci.org/GoogleChrome/lighthouse/jobs/199341666 oh yeah. :) LGTMs? |
ha, same, I was just wondering how that happened. Did a few lighthouse runs and diffed the logs and everything looks the same, though |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
....L
Update: only dot now.. no more landing strip :(
Using the landing strip reporter for us. It looks like this:
Pretty nice as it gives some idea of progress through the suite.
Travis logs every screen change, so I swapped it to the
dot
reporter, which looks like this:Errors in the suite are still reported the exact same way. It's just you see the progress differently
a few other things:
pipe
change in index-test was to avoid seeing "Please provide a url" logged to terminalPTAL!