Report: use the same favicon as the viewer. #1657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
is this just reverting part of #1652? And FWIW, the spec says no prob to |
|
Well, I had created this patch before the other one.
As for the spec yes shortcut icon became valid because of ancient IE and
only for that. Plain icon is the proper syntax.
It's your call what to do with this. I have expressed my personal opinion
on the other PR that loading a huge icon is overkill and second the report
isn't self contained anymore.
A middle solution would be to commit a 48x48 icon and link to that.
…On Feb 8, 2017 20:45, "Brendan Kenny" ***@***.***> wrote:
is this just reverting part of #1652
<#1652>?
And FWIW, the spec says no prob to shortcut
<https://html.spec.whatwg.org/multipage/semantics.html#rel-icon:rel-icon-5>,
even if it is increasingly archaic
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1657 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAVVtWZnDrqE4g0OC0feSz1XZkowaBS6ks5rag09gaJpZM4L5PG3>
.
|
Saves 0.3KB. Also switch to the `link rel=icon` which is spec-compliant.
|
+1 to not loading a 1000px image for the favicon. TBH lighthouse should have something to say about that. :) |
paulirish
approved these changes
Feb 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Saves 0.3KB.
Also switch to the
link rel=iconwhich is spec-compliant.