Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixing the css bug for misaligned score badges on Firefox #1796

Merged
merged 1 commit into from
Mar 1, 2017
Merged

fixing the css bug for misaligned score badges on Firefox #1796

merged 1 commit into from
Mar 1, 2017

Conversation

narendrashetty
Copy link
Contributor

This PR fixes #1762

@XhmikosR
Copy link
Contributor

XhmikosR commented Feb 28, 2017 •
edited
Loading

Why don't you just use margin-top: 2px? Seems simpler to me.

@narendrashetty
Copy link
Contributor Author

@XhmikosR It's just the way I write. Whenever it is absolute positioned I prefer to use top and left instead of margin's. Moreover top affects only the icon and margin can affect other items around it.

If you think I should change, let me know. both of it does the same.

ebidel
ebidel approved these changes Mar 1, 2017
View reviewed changes
Copy link
Contributor

@ebidel ebidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Doesn't appear to have an effect in Chrome, but fixes FF. :)

@ebidel ebidel merged commit c1f108d into GoogleChrome:master Mar 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebidel ebidel ebidel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Report: misaligned score badges on Firefox
3 participants
@narendrashetty @XhmikosR @ebidel