Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report: add legend to decipher iconography left to us by the ancient ones #1841

Merged
merged 1 commit into from
Mar 9, 2017

Conversation

ebidel
Copy link
Contributor

@ebidel ebidel commented Mar 9, 2017

R: all

Time for a legend kids! As we've added more icons, it's become unclear what everything means.

screen shot 2017-03-08 at 5 23 48 pm

@ebidel ebidel changed the title Report: add legend to decipher iconography left to use by the ancient ones Report: add legend to decipher iconography left to us by the ancient ones Mar 9, 2017
@@ -120,7 +126,6 @@ summary {
margin: 0 auto;
max-width: var(--report-width);
background-color: #fff;
box-shadow: 0 0 6px 0 rgba(0,0,0,0.26);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is no longer visible, so removing.

@paulirish
Copy link
Member

My my this is very attractive. Nice stuff, man.

</li>
<li>
<span class="aggregation__header__score score-poor-bg subitem-result__poor">Poor</span>
<span class="footer__key-description">Overall category score is < 73</span>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it < 45 ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Done

Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

definitely clears things up. The current report is...hard to decipher.

I'd normally argue the fact that we need a legend for report scoring is a UX smell and an argument that we need to fix the report itself, but that's in progress so hopefully this isn't a permanent solution :)

@ebidel
Copy link
Contributor Author

ebidel commented Mar 9, 2017

I'd normally argue the fact that we need a legend for report scoring is a UX smell and an argument that we need to fix the report itself, but that's in progress so hopefully this isn't a permanent solution

100% agree. It's gotten out of control. I wanted to get this in before the report redo. No telling how long or what form that will take.

@ebidel ebidel merged commit ed85e6c into master Mar 9, 2017
@ebidel ebidel deleted the key branch March 9, 2017 21:55
ebidel added a commit that referenced this pull request Mar 29, 2017
* Report: add legend to decipher iconography left to us by the ancient ones (#1841)

* Report: print doesn't cut off expanded audit details (#1870)

* Report: increase icon size for a11y (#1856)

* Tweak report colors so that we are WCAG2AA valid.

* Biggin icons

* CLI: add update-notifier. Fixes #1805 (#1890)

* Fixes #1907 - move update-notifier to root (#1908)

* CLI: remove npm prepublish (#1889)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants