-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cherry picks for 1.6 #1923
Cherry picks for 1.6 #1923
Conversation
* Tweak report colors so that we are WCAG2AA valid. * Biggin icons
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sgtm
i'm only slightly hesitant about update-notifier but otherwise feel good.
I think we should probably also get #1918 cherrypicked so that WPT wont be lying about HTTPS to err'one. |
@paulirish that one doesnt merge cleanly because of the changes in 174766f, removing the formatters, and the move to template partials. Lots of stuff happened. The other thing we could do is just roll the current master as the next release. Of course, hold up on merging #1896 until we do a release. |
R: all
Some cherry picks from master so they make it in 1.6. Of note, this includes:
All of these have already landed.