CLI: remove npm prepublish #1889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendankenny
changed the title
lighthouse-cli/compiled-check.js
Outdated
| @@ -6,7 +6,7 @@ const path = require('path'); | |||
| module.exports = function(filename) { | |||
| if (!fs.existsSync(path.join(__dirname, filename))) { | |||
| console.log('Oops! Looks like the CLI needs to be compiled. Please run:'); | |||
| console.log(' npm run install-cli'); | |||
| console.log(' npm run build-cli'); | |||
There was a problem hiding this comment.
if install-cli has build-cli in it now, should this stay install-cli then?
There was a problem hiding this comment.
Suppose it could. Either works.
wardpeet
approved these changes
Mar 24, 2017
ebidel
added a commit
that referenced
this pull request
Mar 28, 2017
ebidel
added a commit
that referenced
this pull request
Mar 29, 2017
* Report: add legend to decipher iconography left to us by the ancient ones (#1841) * Report: print doesn't cut off expanded audit details (#1870) * Report: increase icon size for a11y (#1856) * Tweak report colors so that we are WCAG2AA valid. * Biggin icons * CLI: add update-notifier. Fixes #1805 (#1890) * Fixes #1907 - move update-notifier to root (#1908) * CLI: remove npm prepublish (#1889)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1516
R: all
Finally getting rid of this. It's deprecated in npm 5 and we have convenient build scripts now.