Report: increase icon size for a11y #1856
Conversation
…XhmikosR/lighthouse into XhmikosR-xmr-report-accessibility-colors
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
|
Probably a good reason why but why aren't you using more css vars for the colors. There are a few duplicates like |
agree. i'd actually prefer to close this PR now so that we can start focusing on the report redesign instead of these fixes. ok with you? |
|
I think we should still iterate. I'm still indifferent on a bunch of stuff
in the new report and it's unclear when it would see a first release. This
is good for existing users!
…On Fri, Mar 17, 2017, 2:22 PM Paul Irish ***@***.***> wrote:
I don't think we should spend too much more time tweaking the report if
things are changing.
agree.
i'd actually prefer to close this PR now so that we can start focusing on
the report redesign instead of these fixes. ok with you?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1856 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAOigEzK1xGYCgt0RqcTxQB0Dh-mCvYDks5rmfyGgaJpZM4Ma1dp>
.
|
|
I'm still seeing an issue with |
embiggened! |
|
@paulirish: this isn't valid WCAG2AA as per my comment above. |
* Tweak report colors so that we are WCAG2AA valid. * Biggin icons
* Report: add legend to decipher iconography left to us by the ancient ones (#1841) * Report: print doesn't cut off expanded audit details (#1870) * Report: increase icon size for a11y (#1856) * Tweak report colors so that we are WCAG2AA valid. * Biggin icons * CLI: add update-notifier. Fixes #1805 (#1890) * Fixes #1907 - move update-notifier to root (#1908) * CLI: remove npm prepublish (#1889)
R: all
Expands on #1851 by increasing the size of the icons to 19px to "cheat" at WCAG2AA. See #1851 (comment)
Here's what everything looks like now:
Note, the score labels are set to slightly smaller than they should be but ramping them up to 19px makes them far too big. I've set them to bold 16px, which gets us pretty close.
I don't think we should spend too much more time tweaking the report if things are changing.