remove explicit required generateAuditResult() call

[brendankenny]

basically forever we've required audits to call AuditName.generateAuditResult() on the result they're returning.

static audit(artifacts) {
  return MyGreatAudit.generateAuditResult({
    rawValue: false,
  });
}

This just moves the call to the caller of the audit (Runner._runAudit) instead, making writing an audit require just a little less boilerplate :)

static audit(artifacts) {
  return {
    rawValue: false,
  };
}

[ebidel]

This is awesome! Thanks for the cleanup.

[ebidel]

wait, no longer needed?

[brendankenny]

this is for the AuditResult, not Audit. I'm not sure why requiredArtifacts was on this in the first place

[paulirish]

AuditResut

[brendankenny]

nice catch :)

[brendankenny]

done

[paulirish]

i saw when you were debugging this..

looks like you nuked it because .displayValue is never explictly set?

[paulirish]

If that's true, what is this bit doing?

lighthouse/lighthouse-core/audits/audit.js

Lines 60 to 63 in 3fefe78

	let displayValue = result.displayValue;
	if (typeof displayValue === 'undefined') {
	displayValue = result.rawValue ? result.rawValue : '';
	}

[brendankenny]

looks like you nuked it because .displayValue is never explictly set?

yes. That line in audit.js does the same thing as it did before (so the final result output by Lighthouse will have a displayValue of '845'), but since the unit test is calling .audit() directly, it's not getting the version run through generateAuditResult and so won't have displayValue on it

[paulirish]

roger that.

[brendankenny]

I believe technically all current PRs will still work (no danger in calling Audit.generateAuditResult() on the results of itself), but you can remove Audit.generateAuditResult() from your audit if you feel like it :)

#1840, #1847, #1804, #1695, and #937 looks like they can be updated if desired

[addyosmani]

Thanks for the ping on the page execution breakdowns PR. This change looks pretty sane. LGTM3.