Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix US-centric wording #2432

Merged
merged 2 commits into from
Jun 5, 2017
Merged

Fix US-centric wording #2432

merged 2 commits into from
Jun 5, 2017

Conversation

khempenius
Copy link
Collaborator

Not everyone uses dollars as their currency.

Copy link
Contributor

@benschwarz benschwarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice change!

Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch and thank you for the contribution @khempenius!

Right now the changes have just been made to our test fixtures which won't go out to our users. Could you update the help text of the audit itself? Thanks!

@khempenius
Copy link
Collaborator Author

@patrickhulce Oops, sorry about that. It should now be fixed.

@paulirish paulirish merged commit 60d5333 into GoogleChrome:master Jun 5, 2017
@khempenius khempenius deleted the generic_currency_term branch June 8, 2017 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants