Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core(vulns): snyk snapshot will be updated by PRs #5162

Closed
wants to merge 1 commit into from
Closed

core(vulns): snyk snapshot will be updated by PRs #5162

wants to merge 1 commit into from

Conversation

aviadatsnyk
Copy link
Contributor

Removing this script since it might be misleading, creating the impression the snapshot is updated by it, which is not the case.

Removing this script since it might be misleading, creating the impression the snapshot is updated by it, which is not the case.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@aviadatsnyk
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@patrickhulce
Copy link
Collaborator

Hey there @aviadatsnyk! The script is what downloads and updates the file to make PRs easier though, #5080 makes the output even cleaner. Is there an alternative, even easier approach you'd recommend? :)

@aviadatsnyk
Copy link
Contributor Author

aviadatsnyk commented May 10, 2018

@patrickhulce I'm putting in place automation to open this PR on a weekly basis, with the latest snapshot, so PR creation won't need this script. We'll still enjoy the benefits of the prettier snapshot :D
Regardless, if you think this script is still needed, I'm obviously good with that, it just might be confusing for someone not familiar with the existence of the automation (which is totally on our side..)

@paulirish
Copy link
Member

see #5239 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants