Update first_party_sets.JSON to add acbj.com FPS #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
American Cities Business Journals FPS
Added links to the definitions of set primary and set member in the section "Set-level technical validation" to clarify the meaning of member and primary in this context.
|
Chris,
No I did not, still seem to be making newbie mistakes and navigating my way
around GitHub.
Thanks,
Ralph
On May 2, 2023 at 8:11:35 AM, Chris Fredrickson ***@***.***) wrote:
Hi Ralph - did you mean to associate 2544a8d
<2544a8d>
with this PR? I think we should keep substantive changes separate from
editorial changes, so we should submit 2544a8d
<2544a8d>
as its own PR.
—
Reply to this email directly, view it on GitHub
<#19 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AWC4XZCBVDJ36IOA635GQSDXEEIZPANCNFSM6AAAAAAXQOR5FY>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Clarifying the language in Set-level technical validation bullet to link to definitions of set primary and set member in the definitions section.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
American Cities Business Journals FPS