policy and code changes for robots check #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like you've passed all of the checks! |
|
I opened #246 today. This change breaks for service domains that redirect to another domain that itself doesn't have a X-Robots-Tag. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After investigating the issue relating to case-insensitivity, it was determined that this was not the source of a problem with the robots check as our code uses python's urllib library for requests, which implements a case-insensitive dictionary for request headers.
However, it was determined that there were some issues with the current implementation of the robots check. In particular, we realized that the non-existence of a robots.txt does not prevent web-crawlers from indexing a page. Additionally, the exiting method of checking the 'X-Robots-Tag' would exclude values of the tag that ought to be valid. This PR makes corresponding changes in the code and the submission guide to fix these issues.