Fix test flakiness in Firefox #438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tunetheweb
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #436.
Geckodriver has a bug where, if the webdriver
PageLoadStrategyoption is set to "none" then calls tobrowser.url()can resolve before the browser has actually navigated to the page.This library needs to set the
PageLoadStrategyto "none" for many tests, so the only good way to fix this is to wrap thebrowser.url()function (thenavigateTo()function in this PR) and manually verify that the correct URL is loaded before resolving. As a convenience this wrapped function also exposes an option to conditionally wait for a given documentreadyStatevalue.In addition, since Firefox added support for LCP but does NOT support Element Timing, this PR adds a workaround for LCP tests to wait for
load+rAFas a proxy for ensuring all images are loaded and painted.