Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up the service worker template. #1130

Merged
merged 1 commit into from
Dec 14, 2017
Merged

Clean up the service worker template. #1130

merged 1 commit into from
Dec 14, 2017

Conversation

jeffposnick
Copy link
Contributor

R: @gauntface

Fixes #1118

@workbox-pr-bot
Copy link
Collaborator

PR-Bot Size Plugin

Changed File Sizes

No file sizes have changed.

New Files

No new files have been added.

All File Sizes

View Table
File Before After Change GZipped
packages/workbox-background-sync/build/workbox-background-sync.prod.js 3.17 KB 3.17 KB 0% 1.34 KB
packages/workbox-broadcast-cache-update/build/workbox-broadcast-cache-update.prod.js 1.05 KB 1.05 KB 0% 565 B
packages/workbox-build/build/_types.js 41 B 41 B 0% 61 B
packages/workbox-build/build/index.js 2.52 KB 2.52 KB 0% 1.06 KB
packages/workbox-cache-expiration/build/workbox-cache-expiration.prod.js 3.25 KB 3.25 KB 0% 1.20 KB
packages/workbox-cacheable-response/build/workbox-cacheable-response.prod.js 593 B 593 B 0% 343 B
packages/workbox-cli/build/app.js 4.57 KB 4.57 KB 0% 1.65 KB
packages/workbox-cli/build/bin.js 2.53 KB 2.53 KB 0% 1.07 KB
packages/workbox-core/build/workbox-core.prod.js 6.67 KB 6.67 KB 0% 2.61 KB
packages/workbox-google-analytics/build/workbox-google-analytics.prod.js 1.94 KB 1.94 KB 0% 985 B
packages/workbox-precaching/build/workbox-precaching.prod.js 4.86 KB 4.86 KB 0% 1.89 KB
packages/workbox-range-requests/build/workbox-range-requests.prod.js 1.66 KB 1.66 KB 0% 817 B
packages/workbox-routing/build/workbox-routing.prod.js 2.74 KB 2.74 KB 0% 1.23 KB
packages/workbox-strategies/build/workbox-strategies.prod.js 3.22 KB 3.22 KB 0% 1.00 KB
packages/workbox-sw/build/workbox-sw.js 1.46 KB 1.46 KB 0% 792 B
packages/workbox-webpack-plugin/build/index.js 7.29 KB 7.29 KB 0% 2.45 KB

Workbox Aggregate Size Plugin

☠️ WARNING ☠️

We are using 152% of our max size budget.

Total Size: 22.25KB
Percentage of Size Used: 152%

Gzipped: 8.85KB

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling b2037e4 on sw-template-cleanup into ** on v3**.

Copy link

@gauntface gauntface left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this.

@gauntface gauntface merged commit a28274e into v3 Dec 14, 2017
@gauntface gauntface deleted the sw-template-cleanup branch December 14, 2017 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants