Use a single fetch handler per Router #382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gauntface
approved these changes
Mar 24, 2017
| @@ -122,7 +71,7 @@ class Router { | |||
|
|
|||
| let responsePromise; | |||
| let matchingRoute; | |||
| for (let route of (routes || [])) { | |||
| for (let route of this._routes) { | |||
| if (route.method !== event.request.method) { | |||
There was a problem hiding this comment.
Did we drop support for 'all' like sw-toolbox had?
If so, should we group routes together by method - reducing this loop for each request?
There was a problem hiding this comment.
Yeah, we don't have support for all. I can switch to keeping track of routes per-method to optimize the loop.
|
PTAL at the revised approach to confirm you're still 👍 |
addyosmani
approved these changes
Mar 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R: @addyosmani @gauntface
The diff is pretty busy, but this is basically just shifting the
fetchhandler into theRouterconstructor, and storing the list of routes in a private member variable.Fixes #354