Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure untranspiled node 4+ compat for the v2 webpack plugin #966

Merged
merged 1 commit into from
Nov 1, 2017
Merged

Ensure untranspiled node 4+ compat for the v2 webpack plugin #966

merged 1 commit into from
Nov 1, 2017

Conversation

jeffposnick
Copy link
Contributor

R: @philipwalton @addyosmani @gauntface

Fixes #950

I've tested this locally with an nvm installed version of node 4.x, which is the level we say we support in our package.json.

(As mentioned, this isn't a concern in the v3 codebase, as we're transpiling with @babel/preset-env against our node 4.x target.)

addyosmani
addyosmani approved these changes Nov 1, 2017
View reviewed changes
Copy link
Member

@addyosmani addyosmani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This doesn't seem like it would be too contentious.

@jeffposnick jeffposnick merged commit 7ecec75 into master Nov 1, 2017
@jeffposnick jeffposnick deleted the webpack-plugin-node-4-compat branch November 1, 2017 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addyosmani addyosmani addyosmani approved these changes

@gauntface gauntface gauntface approved these changes

@philipwalton philipwalton Awaiting requested review from philipwalton

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeffposnick @addyosmani @gauntface