shareTarget derives full action URL #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Derive the full action URL from the Web Manifest URL. - Extracts mime-types from share-target.
andreban
force-pushed
the
share-target-improvement
branch
from
023ac4a
to
bb554dc
Compare
PEConn
reviewed
Nov 6, 2020
packages/core/src/lib/TwaManifest.ts
Outdated
| }); | ||
| return twaManifest; | ||
| } | ||
|
|
||
| private static verifyShareTarget( | ||
| webManifestUrl: URL, shareTarget?: ShareTarget): ShareTarget | undefined { | ||
| if (!shareTarget || !shareTarget.action || !shareTarget.params || !shareTarget.params.files) { |
There was a problem hiding this comment.
Can this not be if (!shareTarget?.action || !shareTarget.params?.files)?
|
Unfortunately, when a field is defined as optional like |
PEConn
approved these changes
Nov 6, 2020
| }); | ||
| return twaManifest; | ||
| } | ||
|
|
||
| private static verifyShareTarget( | ||
| webManifestUrl: URL, shareTarget?: ShareTarget): ShareTarget | undefined { |
There was a problem hiding this comment.
The return type can be ShareTarget? right?
There was a problem hiding this comment.
The optional syntax only works for attributes, variable declarations and parameters. Not for return types.
|
Oh, it seems I still don't understand TypeScript. LGTM again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves #21