Escape gradle string in shareTarget / build.gradle

[andreban]

Escapes the gradle string before escaping the JSON. This ensures single quotes
are escaped.

Fixes #673

[PEConn]

Where does this method come from? I can't find the docs for it.

I feel uneasy about escaping a string twice - how do we know this won't do something crazy?

[andreban]

It's set here: https://github.com/GoogleChromeLabs/bubblewrap/blob/main/packages/core/src/lib/TwaGenerator.ts#L404. And the implementation at

bubblewrap/packages/core/src/lib/util.ts

Lines 289 to 298 in 78581c2

	/**
	* Escapes a string that will be written to the Gradle file. The characters need to be escaped
	* multiple times, as they also need to be escaped inside the Gradle file.
	*
	* As an example, "Andre's Code" needs to be written as "Andre\\\'s Code" to the Gradle file, so
	* it is properly escaped when passed to AAPT.
	*/
	export function escapeGradleString(input: string): string {
	return input.replace(/[\\']/g, '\\\\\\$&');
	}

. We own both functions - maybe a test to check if the combination gives the expected results would help?

[PEConn]

Yeah, that would be good, thanks.

[andreban]

Yeah, that would be good, thanks.

Added a test. PTAL

[PEConn]

LGTM % nit thanks

[PEConn]

nit: typo on "how"

[andreban]

fixed