Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eslint] Workaround for 9.0.0 update #1144

Merged
merged 2 commits into from
Apr 8, 2024
Merged

Conversation

emaxx-google
Copy link
Collaborator

@emaxx-google emaxx-google commented Apr 6, 2024

Set the ESLINT_USE_FLAT_CONFIG=false environment variable when running ESLint. This is to workaround the following errors after ESLint got updated to 9.0.0:

  Invalid option '--resolve-plugins-relative-to' - perhaps you meant '--ignore-pattern'?
  You're using eslint.config.js, some command line flags are no longer available. Please see https://eslint.org/docs/latest/use/command-line-interface for details.

Also disable the no-floating-promise plugin since it starts
failing with the following error in ESLint 9.0.0:

  TypeError: context.getScope is not a function

Set the ESLINT_USE_FLAT_CONFIG=false environment variable when running
ESLint. This is to workaround the following errors after ESLint got
updated to 9.0.0:

  Invalid option '--resolve-plugins-relative-to' - perhaps you meant '--ignore-pattern'?
  You're using eslint.config.js, some command line flags are no longer available. Please see https://eslint.org/docs/latest/use/command-line-interface for details.
@emaxx-google emaxx-google changed the title [eslint] Workaround for 9.0.0 update - old format [eslint] Workaround for 9.0.0 update Apr 6, 2024
@emaxx-google emaxx-google marked this pull request as ready for review April 6, 2024 02:05
Copy link

github-actions bot commented Apr 6, 2024

Continuous Integration: All tests passed.
C/C++ test coverage: 73.35% lines.

@emaxx-google emaxx-google merged commit 7d906fa into main Apr 8, 2024
13 checks passed
@emaxx-google emaxx-google deleted the eslint-9.0-fix-config branch April 8, 2024 09:16
emaxx-google added a commit that referenced this pull request Apr 18, 2024
This plugin has been fixed upstream to be compatible with ESLint 9.0.

Hence we can partially revert #1144 to reenable it as part of our lint
checks.
emaxx-google added a commit that referenced this pull request Jun 11, 2024
This plugin has been fixed upstream to be compatible with ESLint 9.0.

Hence we can partially revert #1144 to reenable it as part of our lint
checks.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants