Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ALL dependencies (none needed for use with mdn-confluence) #347

Closed
wants to merge 1 commit into from
Closed

Conversation

foolip
Copy link
Member

@foolip foolip commented Feb 18, 2019

No description provided.

@foolip
Copy link
Member Author

foolip commented Feb 18, 2019

I've confirmed that this works and it will significantly shrink the dependency tree for BCD. This can't be merged before mdittmer/mdn-confluence#41 however, because scripts/build.js depends on the foam2 dependency existing.

@foolip
Copy link
Member Author

foolip commented Feb 18, 2019

I think the only way to not break already published versions of mdn-confluence is actually going to be going with a new branch. I'll push the same contents to mdn-confluence-2 and close this PR.

@foolip foolip closed this Feb 18, 2019
@foolip foolip deleted the mdn-confluence branch February 18, 2019 14:59
foolip added a commit to mdittmer/mdn-confluence that referenced this pull request Feb 18, 2019
foolip added a commit to mdittmer/mdn-confluence that referenced this pull request Feb 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant