Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

html-webpack-plugin V4 (third attempt) #84

Merged
merged 4 commits into from
Oct 22, 2021
Merged

html-webpack-plugin V4 (third attempt) #84

merged 4 commits into from
Oct 22, 2021

Conversation

developit
Copy link
Collaborator

@developit developit commented Oct 22, 2021 •
edited

This is the meat from #43 and #62, updated due to the monorepo cutover.

Fixes #52.

@developit
html-webpack-plugin V4 (third attempt)
469185d 
This is the meat from #43 and #62, updated due to the monorepo cutover.
@developit developit mentioned this pull request Oct 22, 2021
Closed
@developit developit linked an issue Oct 22, 2021 that may be closed by this pull request
Incompatible with html-webpack-plugin v4 #52
Closed
@developit developit marked this pull request as ready for review October 22, 2021 16:14
@developit developit merged commit 3bf052e into main Oct 22, 2021
@developit developit deleted the htmlplugin-v4 branch October 22, 2021 16:23
This was referenced Oct 22, 2021
Closed
Closed
dmnsgn added a commit to dmnsgn/critters that referenced this pull request Oct 23, 2021
@dmnsgn
fix: add createRequire for try/catched require('html-webpack-plugin')…
6f2fbf5 
….getHooks(compilation)

GoogleChromeLabs#43 
GoogleChromeLabs#52
GoogleChromeLabs#62
GoogleChromeLabs#84
@dmnsgn dmnsgn mentioned this pull request Oct 23, 2021
Merged
@nosdoska
Copy link

Thank you @developit!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incompatible with html-webpack-plugin v4
2 participants
@developit @nosdoska