Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add createRequire for try/catched require('html-webpack-plugin').getHooks(compilation) #85

Merged
merged 3 commits into from
Jan 5, 2022

Conversation

dmnsgn
Copy link
Contributor

@dmnsgn dmnsgn commented Oct 23, 2021

@google-cla
Copy link

google-cla bot commented Oct 23, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@dmnsgn
Copy link
Contributor Author

dmnsgn commented Oct 23, 2021

@googlebot I signed it!

dmnsgn added a commit to dmnsgn/frontend-boilerplate that referenced this pull request Oct 24, 2021
- new webpack dev server signature
- remove critters html-webpack-plugin not completely fixed fix (see GoogleChromeLabs/critters#85)
@developit
Copy link
Collaborator

@dmnsgn can you help me understand why this is needed? The code gets compiled to CommonJS only, which allows direct require usage.

@developit developit merged commit cb8c1fc into GoogleChromeLabs:main Jan 5, 2022
@dmnsgn
Copy link
Contributor Author

dmnsgn commented Jan 6, 2022

I have seen you've already merged and published but just in case, here's the explainer: #62 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants