Skip to content
This repository has been archived by the owner on Oct 25, 2024. It is now read-only.

Incompatible with html-webpack-plugin v4 #52

Closed
dominykas opened this issue Mar 25, 2020 · 24 comments · Fixed by #84
Closed

Incompatible with html-webpack-plugin v4 #52

dominykas opened this issue Mar 25, 2020 · 24 comments · Fixed by #84
Labels
has fix webpack Issue specific to critters-webpack-plugin

Comments

@dominykas
Copy link

dominykas commented Mar 25, 2020 •
edited
Loading

When used with latest version of html-webpack-plugin, it crashes with Error: Could not find HTML asset.

It seems the html-webpack-plugin no longer uses the file name as the key in the assets object?

I can also see there's a #43 - anything I can do to move this forward?
@dominykas
Copy link
Author

Just spotted that this may just be a duplicate of #5?

@vitaliyhayda
Copy link

+1 same issue

@mrlss
Copy link

mrlss commented Apr 12, 2020

+1, would be great to fix this issue

@barbu-vlad
Copy link

+1

@developit
Copy link
Collaborator

@dominykas - if you're able to test that PR against your codebase that would be useful. I will try to find some time as well.

@dominykas
Copy link
Author

Thanks, will do. Wasn't sure if that PR is usable.

@dominykas
Copy link
Author

I can't get that to build: Error: Plugin 'jsx' not found... Deps are somewhat out of date, so maybe it is that? I'll try to update the deps and see if that makes it compile, unless someone else gets there first.

@dominykas
Copy link
Author

I patched the dist file manually and tested on one of the repos - the HTML output is identical as before (for practical purposes), so it seems to me that it works 👍.

@dominykas
Copy link
Author

Upgrading microbundle makes the jsx error go away, but produces a 7MB file in dist, which is probably not what needs to happen here, so I think I'll leave this be, unless there's something specific that you want me to do.

@developit
Copy link
Collaborator

@dominykas yep, I can take care of that. It needs the new microbundle --target node flag.

@mrlss
Copy link

mrlss commented May 19, 2020

@developit is there any changes this issue will be fixed?

@buddalasunil999
Copy link

+1

2 similar comments
@DUBANGARCIA
Copy link

+1

@DUBANGARCIA
Copy link

+1

@naiyerasif naiyerasif mentioned this issue Jul 22, 2020
Closed
@stnwk
Copy link

stnwk commented Aug 20, 2020

Would love to see it fixed too! Currently makes it impossible to use with nextjs :/

@blephy
Copy link

blephy commented Sep 30, 2020

+1

3 similar comments
@weihongyu12
Copy link

+1

@rastalamm
Copy link

+1

@DUBANGARCIA
Copy link

+1

@dmnsgn dmnsgn mentioned this issue Jan 8, 2021
Closed
@BzenkoSergey
Copy link

+1

@blephy
Copy link

blephy commented Jun 6, 2021

+10000 !!!!!

@lili21
Copy link

lili21 commented Aug 3, 2021

#43

@developit
Copy link
Collaborator

Hopefully fixed by #84.

@developit developit added has fix webpack Issue specific to critters-webpack-plugin labels Oct 22, 2021
@developit developit linked a pull request Oct 22, 2021 that will close this issue
html-webpack-plugin V4 (third attempt) #84
Merged
@developit developit mentioned this issue Oct 22, 2021
Merged
@dominykas
Copy link
Author

Thanks! 😱

Can't wait to try it out [on Monday].

dmnsgn added a commit to dmnsgn/critters that referenced this issue Oct 23, 2021
@dmnsgn
fix: add createRequire for try/catched require('html-webpack-plugin')…
6f2fbf5 
….getHooks(compilation)

GoogleChromeLabs#43 
GoogleChromeLabs#52
GoogleChromeLabs#62
GoogleChromeLabs#84
@dmnsgn dmnsgn mentioned this issue Oct 23, 2021
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
has fix webpack Issue specific to critters-webpack-plugin
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

html-webpack-plugin V4 (third attempt) GoogleChromeLabs/critters