Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make datalayer name dynamic for GA & GTM #52

Merged
merged 7 commits into from
Jul 18, 2024

Conversation

flashdesignory
Copy link
Collaborator

@flashdesignory flashdesignory commented Jul 16, 2024

This makes dataLayerName required, but default values could be passed in from the wrappers.

example passing in 'GA-DataLayer' and 'GTM-DataLayer':

Screenshot 2024-07-16 at 11 27 56 AM

@kara

@housseindjirdeh
Copy link
Collaborator

Thanks for this. We should probably start doing proper semver versioning when this lands

@flashdesignory
Copy link
Collaborator Author

it'll be a minor release.. it's already set up with semver:

npm run release:minor

Copy link
Contributor

@huang-julien huang-julien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be a bit harder to correctly augment Window

How about accessing it through window.dataLayers[dataLayername] ?

@flashdesignory
Copy link
Collaborator Author

I think it would be a bit harder to correctly augment Window

How about accessing it through window.dataLayers[dataLayername] ?

Made the change, please review @huang-julien @housseindjirdeh

refactor: move datalayers in a datalayers object + type
@flashdesignory flashdesignory merged commit b80a175 into GoogleChromeLabs:main Jul 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants