-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make datalayer name dynamic for GA & GTM #52
Make datalayer name dynamic for GA & GTM #52
Conversation
Thanks for this. We should probably start doing proper semver versioning when this lands |
it'll be a minor release.. it's already set up with semver:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be a bit harder to correctly augment Window
How about accessing it through window.dataLayers[dataLayername]
?
Made the change, please review @huang-julien @housseindjirdeh |
refactor: move datalayers in a datalayers object + type
This makes dataLayerName required, but default values could be passed in from the wrappers.
example passing in 'GA-DataLayer' and 'GTM-DataLayer':
@kara