Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server-side-rendering demo pacakge.json npm install error #50

Closed
stursby opened this issue Sep 15, 2016 · 3 comments
Closed

server-side-rendering demo pacakge.json npm install error #50

stursby opened this issue Sep 15, 2016 · 3 comments

Comments

@stursby
Copy link

stursby commented Sep 15, 2016

npm install in the server-side-rendering demo isn't working. I believe it's the trailing , on line 12. Removing it fixed it for me.

My new package.json

{
  "name": "server-side-rendering",
  "version": "1.0.0",
  "main": "index.js",
  "dependencies": {
    "express": "^4.14.0",
    "handlebars": "^4.0.5",
    "spdy": "^3.4.0",
    "http2": "^3.3.5",
    "mz": "^2.4.0"
  },
  "devDependencies": {}
}
@surma surma closed this as completed in 71be653 Sep 15, 2016
@surma
Copy link
Contributor

surma commented Sep 15, 2016

🙄 Thanks

@stursby
Copy link
Author

stursby commented Sep 15, 2016

No problem! Did you get to the bottom of spdy still serving up HTTP/1 issue? I cloned the repo, booted up the server and also got HTTP/1 (using Node 4).

@surma
Copy link
Contributor

surma commented Sep 15, 2016

Yeah I also tweeted about it. Node 4 is the issue. It works just fine with
node 5. Get nvm :)

On Thu, Sep 15, 2016, 20:47 charlie hield notifications@github.com wrote:

No problem! Did you get to the bottom of the spdy still serving up HTTP/1
issue? I cloned the repo, booted up the server and also got HTTP/1 :|
(using Node 4).


You are receiving this because you modified the open/close state.

Reply to this email directly, view it on GitHub
#50 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAOVzWYWJM78J_va7wvqx3rX0O1AEYK3ks5qqaDcgaJpZM4J-P2K
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants