Support structured streaming writes to BigQuery #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@davidrabinowitz this allows loads for each batch |
varundhussa
force-pushed
the
spark_streaming
branch
from
9aec958
to
abe4b4d
Compare
|
/gcbrun |
davidrabinowitz
requested changes
Jul 9, 2020
connector/src/main/scala/com/google/cloud/spark/bigquery/RowConverter.scala
Outdated
Show resolved
Hide resolved
connector/src/main/scala/com/google/cloud/spark/bigquery/RowConverter.scala
Outdated
Show resolved
Hide resolved
varundhussa
force-pushed
the
spark_streaming
branch
from
b30fafd
to
3dc7e05
Compare
|
@varundhussa Thanks for the clean up! Sorry, I forgot to ask, can you please add an integration test - as it is a new functionality I want to make sure it is properly covered. |
|
/gcbrun |
|
Thanks @davidrabinowitz. I'll write a dataframe selected from BigQuery to a MemoryStream and write tests on top of it. |
|
@davidrabinowitz I have added a append integration test. Not sure how to run it with the build process. |
|
/gcbrun |
davidrabinowitz
approved these changes
Jul 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new Streaming sink
Make load requests per batch DataFrame