Enables PKB to run on a windows controller #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
test this please. |
1 similar comment
|
test this please. |
|
test this please. |
| @@ -71,6 +71,34 @@ Before you can run the PerfKit Benchmaker on Cloud providers you need accounts a | |||
| You also need the software dependencies, which are mostly command line tools and credentials to access your | |||
| accounts without a password. The following steps should help you get the CLI tool auth in place. | |||
|
|
|||
| If you are running on Windows, you will need to install Github Windows | |||
There was a problem hiding this comment.
Will a windows controller work for linux guests? If not, we should call that out.
There was a problem hiding this comment.
Yes a windows controller can run benchmarks on linux guests - that's all this PR enables - windows guests will come later.
|
Looks good. Some small comments. Given that Windows requires some additional prerequisites to be installed, I wonder if we should do a pre-run check for the presence of:
|
fileAdd a gitattributes fileAdd a gitattributes fileAdd a gitattributes fileAdd a gitattributes fileAdd a gitattributes fileAdd a gitattributes file
|
PTAL |
| shell=shell_value, | ||
| stdout=subprocess.PIPE, | ||
| stderr=subprocess.PIPE) | ||
| process.wait() |
There was a problem hiding this comment.
Unlikely given the commands used, but this risks deadlock if cmd produces a lot of output. Prefer check_output, communicate, or opening a handle to os.devnull and using it for stdout and stderr.
ehankland
added a commit
that referenced
this pull request
May 27, 2015
Enables PKB to run on a windows controller
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.