Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for asyncpg driver #57

Closed
jackwotherspoon opened this issue Jun 13, 2023 · 6 comments · Fixed by #199
Closed

Add support for asyncpg driver #57

jackwotherspoon opened this issue Jun 13, 2023 · 6 comments · Fixed by #199
Assignees
Labels
priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@jackwotherspoon
Copy link
Collaborator

Feature Description

Now that Connection pooling is supported with asyncpg and SQLAlchemy, we should support it as a driver with this library.

Sample code

No response

Alternatives Considered

No response

Additional Details

No response

@jackwotherspoon jackwotherspoon self-assigned this Jun 13, 2023
@jackwotherspoon jackwotherspoon added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. labels Jun 13, 2023
@jackwotherspoon
Copy link
Collaborator Author

jackwotherspoon commented Sep 21, 2023

While asyncpg is not yet supported by the AlloyDB Python Connector, samples showcasing how to connect to AlloyDB using asyncpg without this library (native asyncpg connection pool, SQLAlchemy pool samples) have been added as part of #121

@enocom
Copy link
Member

enocom commented Nov 16, 2023

@kurtisvg
Copy link

This feature is necessary for fully supporting AlloyDB in the Database Query Extension repo and our WIP LangChain integrations.

@RahulDubey391
Copy link
Contributor

Hi @enocom , @jackwotherspoon if it's okay can I work on this issue? Since the same is implemented for Cloud SQL Python Connector, I can use it as a reference.

@jackwotherspoon
Copy link
Collaborator Author

if it's okay can I work on this issue? Since the same is implemented for Cloud SQL Python Connector, I can use it as a reference.

Hi @RahulDubey391, thanks for the interest here 😄

This issue is currently blocked by MagicStack/asyncpg#1054

We are going to be working on a PR to asyncpg in order to try and resolve it this week. I will update this issue when work is unblocked and see if you are still interested. 👍

@RahulDubey391
Copy link
Contributor

Thanks @jackwotherspoon for letting me know. Sure I'll look into it once it's unblocked!

@enocom enocom assigned enocom and unassigned jackwotherspoon Jan 9, 2024
enocom added a commit that referenced this issue Jan 10, 2024
enocom added a commit that referenced this issue Jan 10, 2024
enocom added a commit that referenced this issue Jan 10, 2024
enocom added a commit that referenced this issue Jan 10, 2024
enocom added a commit that referenced this issue Jan 11, 2024
enocom added a commit that referenced this issue Jan 11, 2024
enocom added a commit that referenced this issue Jan 11, 2024
enocom added a commit that referenced this issue Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants