This repository has been archived by the owner on Sep 8, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 35
Master updating runtimes nov2017 #80
Merged
ivannaranjo
merged 9 commits into
GoogleCloudPlatform:master
from
ivannaranjo:master_updating_runtimes_nov2017
Nov 28, 2017
Merged
Master updating runtimes nov2017 #80
ivannaranjo
merged 9 commits into
GoogleCloudPlatform:master
from
ivannaranjo:master_updating_runtimes_nov2017
Nov 28, 2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ping. |
ILMTitan
approved these changes
Nov 27, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure why you are renaming the temp_builders_root folder, but otherwise LGTM.
@@ -37,7 +37,7 @@ else | |||
fi | |||
|
|||
# Where to store the modified app definitions. | |||
readonly temp_builders_root=$(mktemp -d -t test_run) | |||
readonly temp_builders_root=$(mktemp -d -t test_run.XXXX) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure why you are adding to this filename.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The mktemp tool requires multiple X
characters so it can generate a unique name in Linux. It does not require this on Mac. I was running this script on my Linux box when I got the warning.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the new images for the November release of the .NET Core runtime.
Fixes #79