-
Notifications
You must be signed in to change notification settings - Fork 588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install kubectl in gcloud builder #2
Conversation
Thanks, and sorry that it took so long to notice this PR. Unfortunately we cannot accept PRs to this repo - it is currently "mirror-out" from our internal codebase. I'll add it from the inside. |
Now that I think about usage a bit, I'm not so sure that this PR is sufficient. |
Sounds good @skelterjohn. I was going to go about it by doing something like this for the command:
|
That would work, certainly, but doesn't sit well with me for usage I want to document or put in examples :) Maybe a kubectl builder that uses the gcloud builder as a base image, and has a wrapper script that checks some env vars? In this case, we could piggy-back on the env already used by gcloud and have people set CLOUDSDK_CONTAINER_CLUSTER=foobar, and the wrapper script does as you indicate. |
<opinion>The UX of having it all spelled out and obvious in the command seems much better than a tucked in interpretation of an env variable with a wrapper script.</opinion> |
Thanks, I appreciate your thoughts there. I've got something that allows either to work - you can spell it out like you do in your example (if you use sh as the entrypoint), or you can provide the env vars necessary. Unfortunately, this is blocked on the scopes we give to your build. Soon-ish we hope to give your builds the https://www.googleapis.com/auth/cloud-platform scope (ie, everything) and rely on the robot permissions for restrictions. But right now the scopes don't allow getting credentials for the cluster. When this changes, I'll update this thread. |
ed8bfb2 broke the build ``` Step #2: Already have image: gcr.io/argo-integration-testing/bazel Starting Step #2 Step #2: INFO: Reading 'startup' options from /root/.bazelrc: --output_base=/workspace Step #2: .................. Step #2: Blaze should not be called from a Blaze output directory. The pertinent workspace directory is: '/workspace/examples' Finished Step #2 ```
Don't suppose any progress has been made on this? Would really love to be able to deploy more easily to my GKE cluster from Cloud Builder. |
Did you see this discussion. #22 |
I did not so thanks for linking that. :) |
As there is a workaround to get kubectl working in #22, I guess, there is nothing wrong with having kubectl installed inside the image. WDYT? |
It's certainly possible for people to use kubectl today, with some stretching. But for a version we officially support, it's important that it work well out of the box. Hopefully resolved soon, stay tuned! |
Closing; we now have a supported kubectl Build Step. Please re-open (or open a new PR or issue) if our supported (Note: since @skelterjohn's original reply on Feb 21, we are now able to accept PRs.) |
…ate-docs Update README with more instructions.
Update Terraform to version 0.12.3
No description provided.