Refactor uploader package for easier library use #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bendory
approved these changes
May 22, 2018
jakebiesinger-onduo
pushed a commit
to jakebiesinger/cloud-builders
that referenced
this pull request
Nov 3, 2019
…#282) * Unify uploader and fetcher * Librarize uploader package
k0uki
pushed a commit
to OLTAInc/cloud-builders
that referenced
this pull request
Oct 5, 2021
…#282) Reduces need for installation of additional packages to perform basic tasks during build time. Same image build process as packer. alpine pinned to 3.9.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than having the
uploaderpackage take a directory to walk, the package now has anEnqueuemethod which enqueues thepathto upload. This makes it more generally usable in other contexts, such as in Skaffold (GoogleContainerTools/skaffold#568)gcs-uploader/main.gois now responsible for doing thefilepath.WalkandEnqueueing paths to upload.This change also:
buildHTTPClientmethods fromgcs-fetcher/main.goandgcs-uploader/main.goGCSFetcher->FetcherandGCSUploader->Uploader