Attempt to clarify use of Golang image, Modules and Mirror #517
Conversation
go/README.md
Outdated
| @@ -4,27 +4,70 @@ This builder runs the `go` tool (`go build`, `go test`, etc.) | |||
| after placing source in `/workspace` into the `GOPATH` before | |||
| running the tool. | |||
|
|
|||
| This functionality is not necessary if you're building using | |||
| # Using `Golang` and [Go Modules](https://github.com/golang/go/wiki/Modules) | |||
There was a problem hiding this comment.
Docker image names must be lowercase, so I'd prefer to refer to it as golang
go/README.md
Outdated
| in Go 1.11+, and you can **build with the standard | ||
| [`golang`](https://hub.docker.com/_/golang) image on Dockerhub | ||
| instead:** | ||
| in Go 1.11+. You can **build** with the `golang` image (not a Builder) from [Dockerhub](hub.docker.com/library/golang) and Google's Container Registry [mirror](mirror.gcr.io/library/golang): |
There was a problem hiding this comment.
"(not a Builder)" is a bit misleading; any image can be used as a "builder" -- the term is fairly ill-defined -- including the golang image.
go/README.md
Outdated
| in Go 1.11+, and you can **build with the standard | ||
| [`golang`](https://hub.docker.com/_/golang) image on Dockerhub | ||
| instead:** | ||
| in Go 1.11+. You can **build** with the `golang` image (not a Builder) from [Dockerhub](hub.docker.com/library/golang) and Google's Container Registry [mirror](mirror.gcr.io/library/golang): |
There was a problem hiding this comment.
We configure GCB to use the GCR mirror by default, so there's no need to explicitly request the mirrored version. Just referencing golang will pull through the GCR mirror if available, and not if not.
There was a problem hiding this comment.
Interesting. How does this square with: https://issuetracker.google.com/issues/137170318
There was a problem hiding this comment.
That I don't know, I'd have to talk to the GCR team to understand more.
In general I think we should not ask users to request from mirror.gcr.io directly, but instead just configure their Docker installation to use the mirror, or in the case of GCB, just rely on it already configuring that.
| env: | ||
| - GO111MODULE=on | ||
| args: ['go','get','-u','github.com/golang/glog'] | ||
| volumes: |
There was a problem hiding this comment.
You can now specify build-wide volumes and envs using .options.env and .options.volumes, to avoid having to repeat yourself.
There was a problem hiding this comment.
IDNKT. Will reflect.
…udPlatform#517) * Attempt to clarify Modules and Mirror * Reflect @imjasonh feedback
@imjasonh -- as discussed via email, a proposal to:
GolangimageGolangimage's use of/goand Cloud Build's use of/workspaceGOPROXY=https://proxy.golang.orgmirror.gcr.io/library/golang-- will file a separate bug about the Golang version omission