farisjarrah/cloud-sql-docs: Fixed a path error in an Cloud SQL exampl… #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
farisjarrah
requested review from
morgante,
ocsig and
sjvanrossum
as code owners
|
I added another template for private networking. That network configuration worked for me in another deployment. Let me know if all this is suitable for you folks. |
|
Thank you for the great contribution. Would you be able to send your changes against to the cft-dm-dev branch? Otherwhise I'm holding this PR back until the end of the week when we plan to merge to master. |
|
Sure thing, I can probably get this done by this evening. |
…stream dev branch
|
I've rebased off of cft-dm-dev and set that as my new upstream branch I still need to double check the schema though. |
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
|
@googlebot I consent. |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
…nsured that the templates matched the cft-dm-dev branch schema for cloud sql
|
Already been merged, but I did double check the schema and it matched up, thanks! |
|
I did run the schema checks before merge. Thank you for your contribution! |
ocsig
added a commit
that referenced
this pull request
Sep 3, 2019
* [DM] cloud_router: refactoring (#64) #51 - Added version, links to docs - Added support for "description" - Switched to using type provider - Added support for cross-project resource creation - Added missing fields: - bgp (only asn is supported now) - nats - bgpPeers - interfaces - Added basic schema unit tests * [DM] project: refactoring (#59) #57 - Added version, links to docs - Added "labels" support - Added resource name prefix - Updated compute-beta to compute-v1 - Fixed deprecated gcp-types/compute-v1:compute.subnetworks.setIamPolicy bindings - Refactored default resources removal: remove code duplication - Added usageExportBucket name prefix * [DM] gcs_bucket: refactoring (#83) #66 - Added version, links to docs - Added uniqueItems: true to lists - Switched to using type provider - Added cross-project creation support - Added additionalProperties: false for nested object - Fixed "bindings" schema - Added support for "requesterPays" - Added support for "acl", "billing", "cors", "defaultEventBasedHold", "defaultObjectAcl", "encryption", "iamConfiguration", "retentionPolicy" - Fixed resource name * [DM] network: refactoring (#61) #56 - Added version, links to docs - Switched to using type provider - Added support for cross-project resource creation (both network and subnetwork) - Added oneOf check for subnets: autoCreateSubnetworks should be exclusive with subnet list - Fixed network & subnetworks resources names - Added support for "description", "routingConfig" to network - Fixed "secondaryIpRanges" definition in subnetwork - Added basic schema unit tests * [DM] cloud_sql: refactoring (#62) #54 - Added version, links to docs - Switched to using type provider - Added enum for "databaseVersion", "region", "settings.pricingPlan", "settings.replicationType" - Added additionalProperties: false for nested object - Fixed "users" schema - Added basic schemas unit tests * [DM] cloud_spanner: refactoring (#63) #53 - Added version, links to docs - Added support for "labels" - Switched to using type provider - Made "name" optional, correctly handle it - Added support for cross-project resource creation - Updated "instanceConfig" enum with new values - Added basic schema unit tests - Added additionalProperties: false for nested objects * [DM] instance: refactoring (#84) #70 - Added version, links to docs - Switched to using type provider - Added cross-project creation support - Added additionalProperties: false for nested objects - Added support for "description", "networkInterfaces[].accessConfigs[]", "networkInterfaces[].aliasIpRanges[]", "disks", "scheduling", "labels", "minCpuPlatform", "guestAccelerators", "deletionProtection", "hostname", "shieldedInstanceConfig", "shieldedInstanceIntegrityPolicy": [docs](https://cloud.google.com/compute/docs/reference/rest/v1/instances/insert) - Fixed resource name * [DM] autoscaler: refactoring (#82) #67 - Added version, links to docs - Switched to using type provider - Added cross-project creation support - Added additionalProperties: false for nested object - Fixed resource name * [DM] cloud_function: refactoring (#65) #52 - Added version, links to docs - Switched to using type provider - Upgraded API version: v1beta2 -> v1 - Added cross-project creation support (including upload.py) - Added support for "labels", "environmentVariables" fields - Renamed "region" to "location" with backward compatibility + there is oneOf check - Added new runtimes, change default to nodejs10 - Fixed function upload code (it is not redeployed after code upload when using other project) - Updated source upload logic: - If "sourceRepository" field is present, use it as-is - If "sourceRepositoryUrl" field is provided, change it to "sourceRepository" format - If "sourceArchiveUrl" is provided, use it as-is - If "localUploadPath" is present, create cloudbuild build for function zip file. Use "sourceArchiveUrl" as target or generate it automatically (providing generated path via ""sourceArchiveUrl") - If "sourceUploadUrl" is present, use it as-is - All other parameter combinations should be restricted * Fixes #55: DM/folder: refactoring #55 - added version, links to docs - fixed folder resource names: use base resource name as a template - added oneOf check for folderId/orgId + fix incorrect schema for array - fixed "displayName" regex - made "name" field optional - using the same format for parent as in project + fixed name prefix to plural * Fixes #69: DM/managed_instance_group: refactoring (#90) #69 - Added version, links to docs - Switched to using type provider - Added cross-project creation support - Added additionalProperties: false for nested objects - Fixed resource name * [DM] instance_template refactoring (#89) #68 - Added version, links to docs - Switched to using type provider - Added cross-project creation support - Added additionalProperties: false for nested objects - Added support for "networkInterfaces[].accessConfigs[]", "disks", "scheduling", "minCpuPlatform", "guestAccelerators", "shieldedInstanceConfig", "sourceInstance", "sourceInstanceParams" - Fixed resource name * Fixes #119: DM/route: refactoring (#120) #119 - Added version, links to docs - Switched to using type provider - Added support for cross-project resource creation - Fixed resource names - Fixed arrays, objects and required fields (check for routeType + make old scheme optional) - Added missing fields: "description", "nextHopInstance", "nextHopInstance", "nextHopNetwork", "nextHopGateway", "nextHopVpnTunnel" * Fixes #119: DM/route: refactoring #119 Small typo, rechecked tests * CFT build config to point to the correct license file * [DM][FIX] Project: SA can not be created ("project_id" field is unknown) #149 * [DM] iam_member: refactoring (#129) * Fixes #116: DM/iam_member: refactoring #116 * [DM] firewall: refactoring (#100) #99 #91 - Added version, links to docs - Switched to using type provider - Added support for cross-project resource creation - Upgraded compute-beta to compute-v1 - Fixed resource names - Added schema to "rules": "name", "description", "priority", "sourceRanges", "destinationRanges", "sourceTags", "targetTags", "sourceServiceAccounts", "targetServiceAccounts", "allowed", "denied", "direction", "logConfig", "disabled" * [DM] bastion: refactoring (#102) #101 - Added version, links to docs - Switched to using type provider - Added support for cross-project resource creation - Fixed resource names - Fixed instance.py outputs (it lacks internalIp/externalIP) - Fixed endless loops in tests * [DM] backend_service: refactoring (#104) #103 - Added version, links to docs - Switched to using type provider - Added support for cross-project resource creation - Added new fields: "backends[].maxRatePerEndpoint, .maxConnectionsPerEndpoint", "iap", "customRequestHeaders[]" - Changed healthCheck to healthChecks[] - Added checks for INTERNAL/EXTERNAL LB schemes for all relevant fields - Added checks for backends[].balancingMode * [DM] bigquery: refactoring (#106) #105 - Added version, links to docs - Switched to using type provider - Added support for cross-project resource creation - Added missing fields to datasets: "friendlyName", "defaultPartitionExpirationMs", "labels", "access" - Added missing fields to tables: "description", "labels", "clustering", "requirePartitionFilter", "externalDataConfiguration", "encryptionConfiguration" - Fixed resource names - Added uniqueItems: true and additionalProperties: false * [DM] gke: refactoring (#111) #110 GoogleCloudPlatform/deploymentmanager-samples#436 GoogleCloudPlatform/deploymentmanager-samples#463 - Added version, links to docs - Switched to using type provider - Added support for cross-project resource creation - Fixed resource names - Removed deprecated "nodeConfig", switch to "nodePools[].config" - Removed deprecated "initialNodeCount", switch to "nodePools[].initial_node_count" - Removed deprecated "privateCluster", "masterIpv4CidrBlock" -> "privateClusterConfig" - Updated parameters: "masterAuth", "loggingService", "monitoringService", "addonsConfig", "ipAllocationPolicy" and others - Added support for "nodePools[]", "binaryAuthorization", "autoscaling", "networkConfig", "defaultMaxPodsConstraint", "resourceUsageExportConfig", "authenticatorGroupsConfig", "verticalPodAutoscaling", "tierSettings", "workloadIdentityConfig", "nodeConfig->diskType,sandboxConfig,shieldedInstanceConfig", "enableTpu", "databaseEncryption" - Added uniqueItems: true and additionalProperties: false * [DM] kms: refactoring (#128) #117 - Added version, links to docs - Added support for cross-project resource creation - Fixed resource names - Added missing algorithms * [DM] pubsub: refactoring (#125) #118 - Added version, links to docs - Switched to using type provider - Added support for cross-project resource creation - Fixed resource names - Added topic fields: "labels" - Added subscription fields: "pushConfig", "retainAckedMessages", "messageRetentionDuration", "labels", "expirationPolicy" * Fixes #115: DM/iam_custom_role: refactoring (#130) #115 - Added version, links to docs - Added support for cross-project resource creation - Added support for "stage" field * [DM] ip_reservation: refactoring (#133) #132 - Addde version, links to docs - Switched to using type provider - Added support for cross-project resource creation - Added missing fields: "prefixLength", "networkTier" - Fixed field checks * [DM] IAM_member folder and org support (#166) #162 Added support for folders and organizations: gcp-types/cloudresourcemanager-v1:virtual.projects.iamMemberBinding gcp-types/cloudresourcemanager-v2:virtual.folders.iamMemberBinding gcp-types/cloudresourcemanager-v1:virtual.organizations.iamMemberBinding * [DM] healthcheck: refactoring (#131) #124 - Added version, links to docs - Switched to using type provider - Added support for cross-project resource creation - Added support for missing fields: "description", "name" * [DM] nat_gateway: refactoring (#134) #123 - Added version, links to docs - Switched to using type provider - Added support for cross-project resource creation * [DM] ssl_certificate: refactoring (#152) #148 - Added version, links to docs - Switched to using type provider - Added support for cross-project resource creation - Fixed resource names * [DM] url_map: refactoring (#155) #153 - Added version, links to docs - Switched to using type provider - Added support for cross-project resource creation - Fixed resource names * [DM] target_proxy: refactoring (#156) #154 - Added version, links to docs - Switched to using type provider - Added support for cross-project resource creation - Fixed resource names - Upgraded compute api version - Fixed fields descriptions, add checks to arrays and objects - Added support for "sslCertificates" * [DM] forwarding_rule: refactoring (#157) #141 - Added version, links to docs - Switched to using type provider - Added support for cross-project resource creation - Fixed resource names - Fixed descriptions - Added support for fields: "serviceLabel", "networkTier", "allPorts" - Added strict properties checking * [DM] external_load_balancer: refactoring (#159) #140 - Added version, links to docs - Switched to using type provider - Added support for cross-project resource creation - Fixed resource names * [DM] Internal_load_balancer: refactoring (#168) #143 - Added version, links to docs - Switched to using type provider - Added support for cross-project resource creation - Fixed resource names * [DM] haproxy: refactoring (#169) #142 - Added version, links to docs - Switched to using type provider - Added support for cross-project resource creation - Fixed resource names - Fixed imports * [DM] dataproc: refactoring (#170) #137 - Added version, links to docs - Switched to using type provider - Added support for cross-project resource creation - Fixed resource names - Added missing fields: "labels", "<nodes>.imageUri", "<nodes>.isPreemptible", "<nodes>.accelerators", "softwareConfig.optionalComponents", "encryptionConfig" - Mergeed master, nodes and secondary nodes * [DM][BugFix] GKE template examples (#172) #171 * [DM] dns_managed_zone: refactoring #138 (#176) * [DM] Project Factory readme extension Adding Service Usage Admin to prerequisites * [DM] Patch IAM member to projectID (#187) * [DM] Patch IAM member to projectID Project ID was forcefully overwritten to context.env['project'] * [DM] CloudDNS - Backwards compatibility and bugfixes (#192) Added Backward Compatibility with the old property zoneName. Added Backward Compatibility Integration Test. Fixed Identation of integration tests and added project parameter for gcloud calls. Adjusted schema paterns. Added description for all the tests. Updated README * Fix couple of typographical errors. * Fix prerequisites target name in docs and Makefile * [DM] - IAM needs to depends on SA existance (#222) #175 * [DM] interconnect_attachment: refactoring (#195) #183 - Added version, links to docs - Switched to using type provider - Added support for cross-project resource creation - Fixed resource names - Added missing fileds: "pairingKey", "vlanTag8021q", "adminEnabled", "candidateSubnets", "bandwidth", "partnerMetadata", "partnerAsn" * [DM] runtime_config: refactoring (#201) #184 - Added version, links to docs - Switched to using type provider - Added support for cross-project resource creation - Fixed resource names - Standardized naming * [DM] interconnect: refactoring (#196) #182 - Added version, links to docs - Switched to using type provider - Added support for cross-project resource creation - Fixed resource names - Updateed/added fields: "linkType", "requestedLinkCount", "interconnectType" * [DM] backwards compatibility and styling fix Fixed Backward Compatibility Support. Fixed pydocstyle D210, D202. Restricted dnsName pattern to comply with RFC. 1035 #138 (#194) * [DM] Cloud DNS - Fix/162 (#165) * [DM] CloudDNS - Backwards compatibility and bugfixes (#192) Added Backward Compatibility with the old property zoneName. Added Backward Compatibility Integration Test. Fixed Identation of integration tests and added project parameter for gcloud calls. Adjusted schema paterns. Added description for all the tests. Updated README * Fixes #162: [DM] IAM_member folder and org support #162 #151 Added support for folders and organizations: gcp-types/cloudresourcemanager-v1:virtual.projects.iamMemberBinding gcp-types/cloudresourcemanager-v2:virtual.folders.iamMemberBinding gcp-types/cloudresourcemanager-v1:virtual.organizations.iamMemberBinding Updated tests to be non-interactive + added tests for folders Fixed removal of mid-list members * [DM] Refactored dns_records template #139 (#197) * [DM] vpn: refactoring (#202) #186 - Added version, links to docs - Switched to using type provider - Added support for cross-project resource creation - Fixed resource names - Added missing router property * [DM] stackdriver_metric_descriptor: refactoring (#207) #185 - Added version, links to docs - Added support for cross-project resource creation - Fixed resource names - Added support for "launchStage", deprecated "metadata.launchStage" - Added checks for "unit" * [DM] cloudbuild: refactoring (#211) #180 - Added version, links to docs - Added support for cross-project resource creation - Fixed resource names - Added checks to objects and arrays - Fixed "artifacts.objects" property, add "options.workerPool, env, secretEnv, volumes" for cloudbuild - Added "tags", "github", "triggerTemplate.revision->commitSha" for trigger * [DM] cloud_tasks: refactoring (#212) #179 - Added version - Fixed resource names * [DM] network_peering: refactoring (#214) #145 - Added version, links to docs - Added support for cross-project resource creation - Fixed resource names - Added support for "networkPeering" field * [DM] Shared VPC Subnet IAM refactoring Refactored shared_vpc_subnet_iam template. Added bindings and policy syntax tests(in addition to legacy syntax check) (#215) * [DM] Backend_service update example according to schema validation (#221) #220 * [DM] cloud_tasks: refactoring (#208) #179 - Added version - Fixed resource names * [DM] logsink: refactoring (#228) #144 - Added version, links to docs - Added support for cross-project resource creation - Fixed resource names * Enable users to specify network reference in the firewall DM template. * Enable GKE DM template to support 'latest' initial cluster version. * Change the logic of checking initial cluster version in the GKE DM template. * [DM] Org_Policy updates(#231) - Added version, links to docs - Fixed resource names - Fixed pydocstyle warnings - Added schema validation against the API documentation - Added project parameter to gcloud deployment-manager calls * [DM] forseti: refactoring (#239) #181 - Added version, links to docs - Switched to using type provider * [DM] Enable cloud_router DM template to support networkURL. (#235) * Enable cloud_router to support networkURL. * Update cloud_router DM schema for netowrkURL and networkName. * Continue to use network instead of networkName so that the CL is not a breaking change. * Update cloud_router DM schema. * Update cloud_router.py.schema * [DM] logsink test fix Following topic rename in test file * [DM] Small fixes to templates. (#268) * [DM] fix healthcheck type property #270 * [DM] fixing CloudSQL example * HA proxy example remove unneeded import * [DM] adding schema validation test * [DM] bastion bats improve * [DM] Bastion test disk size correction * [DM] Fixes #269: DM dev branch quality control (#282) * Fixes #269: DM dev branch quality control #269 - Fixed templates/bigquery/tests/integration/bigquery.bats * Fixes #269: DM dev branch quality control #269 - Fixed templates/haproxy/tests/integration/haproxy.bats * Fixes #269: DM dev branch quality control #269 - Fixed templates/instance_template/tests/integration/instance_template_networks.bats * Fixes #269: DM dev branch quality control #269 - Fixed templates/instance/tests/integration/instance.bats * Fixes #269: DM dev branch quality control #269 - Fixed templates/instance/tests/integration/instance_template/instance_template.bats * Fixes #269: DM dev branch quality control #269 - Fixed templates/shared_vpc_subnet_iam/tests/integration/shared_vpc_subnet_iam.bats * [DM] Fixing External LB test cleanup * [DM] Updating changelog (#293) * Updating changelog * Adding container images to run tests in CI. * [DM] warning for bastion host sudoers (#297) Priorities are default to 1000, not incrementing. Adding debug messages. * [DM] Isolate a single template from route DM template. (#257) * Split route DM template into two parts: a route group and a single route. * Enable single_route DM template to accept VPN tunnel URL. * Always use context.env name in single_route DM template. * Allow users to specify single_route real name in DM template. * [DM] Enable VPN DM template to support static routing. (#234) * Enable VPN DM template to support static routing. * remove two string init, recover comments for address API link. * recover name and project on the adress resource in VPN DM template. * Update VPN DM template schema. * Change routerName back to router. * Enable VPN template to output an URI of the created VPN tunnel. * VPN DM schema add uniqItems on selectors. * [DM] Fixed a path error in an Cloud SQL exampl… (#300) * farisjarrah/cloud-sql-docs: rebased off of cft-dm-dev to submit to upstream dev branch * farisjarrah/cloud-sql-docs: fixed postgres version number type, and ensured that the templates matched the cft-dm-dev branch schema for cloud sql
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…e and added CFT commands for deployment and deleting Cloud SQL instances. Added an example template for Postgres.
Greetings,
I have been working on a CFT Cloud SQL deployment and saw a few things that could possibly use some fixing, and also a potential quality of life improvement for your users.
dns_managed_zone, Changed to:cloud_sqlexample/cloud_sql.yamlIf there are any changes you would like to see or any other fixes, please don't hesitate to let me know and I will try my best to get them patched up.
Thanks!
Faris